use KanikoEnv in all integration executor invocations#808
Open
mzihlmann wants to merge 1 commit into
Open
Conversation
mzihlmann
added a commit
that referenced
this pull request
Jun 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mzihlmann
added a commit
that referenced
this pull request
Jun 26, 2026
mzihlmann
added a commit
that referenced
this pull request
Jun 27, 2026
mzihlmann
added a commit
that referenced
this pull request
Jun 27, 2026
mzihlmann
added a commit
that referenced
this pull request
Jun 27, 2026
* graduate feature flags for v1.28.0 * disable FF_KANIKO_REPRODUCIBLE_PRESERVE_BASE_LAYERS in TestPushFromArtifact * ungraduate FF_KANIKO_REPRODUCIBLE_PRESERVE_BASE_LAYERS, defer to v1.29.0 * drop redundant TestPushFromArtifact flag override, covered by KanikoEnv coverage in #808 * remove FF_KANIKO_OCI_STAGES, OCI layout stages now unconditional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several integration tests build the executor docker command by hand and never applied KanikoEnv, so they ran the executor on defaults instead of the suite's feature-flag matrix. That gap is what let the REPRODUCIBLE_PRESERVE_BASE_LAYERS divergence stay hidden until the v1.28.0 graduation flipped its default, because the one test that compares a tar artifact against a direct push (TestPushFromArtifact) never saw the flag on.
Route every executor invocation through a shared addKanikoEnvFlags helper so all tests exercise the same flags. TestPushFromArtifact keeps FF_KANIKO_REPRODUCIBLE_PRESERVE_BASE_LAYERS disabled, layered after KanikoEnv, because the docker-archive --tar-path writer cannot preserve OCI base layers and the push-from-artifact image would otherwise not match the direct push.